Merged
Conversation
Contributor
|
Great, thank you! Just added a message for context that will tell us if it's the first formatting pass or idempotence check that failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an idempotence check in tests.
To make tests pass with the idempotence check I made two fixes:
Fix the case when extends statement was stealing docstring from the next statement
previously formatted as
and when there is no blank line around docstring attach it to the next statement instead of the extends statement:
previously formatted as
Now in both cases it attaches docstring to the statemet
When reordering attach docstring to the class only if it does not attached to the statement
Previously code with
--reorder-codegot transformed into
Now it correctly attaches docstring to the function definition.
I'm not that familiar with the reordering code, so I hope I didn't break anything. I also left the TODO intact because I have a feeling I didn't cover all the cases.