Misc fixes#70
Merged
NathanLovato merged 1 commit intoGDQuest:mainfrom Sep 23, 2025
Merged
Conversation
Contributor
|
Thanks much! |
Contributor
Author
|
Finally I don't have to rebase this constantly anymore |
Comment on lines
+220
to
+222
| if let Cow::Owned(replaced) = re.replace_all(&self.content, "\n") { | ||
| self.content = replaced; | ||
| } |
Contributor
There was a problem hiding this comment.
Cool, Cow is a built-in copy on write mechanism? Is it like if replace_all replaces anything it returns a new string, otherwise a sort of reference or type meaning no changes are needed?
Contributor
Author
There was a problem hiding this comment.
Correct! You can check replace_all's description. It basically returns a reference to the haystack (content) if it didn't find anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of minor fixes
reorder.rsformatter.rs:replace_alldidn't replace anythinghandle_two_blank_line()a method ofFormatter.reorder.rs:BUILTIN_VIRTUAL_METHODS.extract_*_name()methods: updated to use methods likestrip_prefix()andsplit_once()instead of manual string manipulation