Don't apply pre/postprocessing inside strings#80
Merged
NathanLovato merged 5 commits intoGDQuest:mainfrom Sep 25, 2025
Merged
Conversation
fstxz
reviewed
Sep 25, 2025
fstxz
reviewed
Sep 25, 2025
Contributor
|
Great, thank you! The cleaning function was to do a pass of whitespace cleanup I think, but for sure it should not happen in strings ideally. It can be removed for now if nobody feels a strong need for it - many code editors do or can do that for you on save. This said it can optionally be kept. |
Contributor
Author
|
I added it in 78c34a3 and IIRC to fix a trailing whitespace after delimiter was inserted, but now that we handle vertical spacing outside of topiary I think we can remove that function to allow trailing whitepspaces in multiline strings. |
Contributor
|
Sounds good to me. |
Contributor
Author
|
Other than the name for test files (I can't come up with a name that doesn't take a whole screen), I think it is good to go. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #79.
I'm not sure about
clean_up_lines_with_only_whitespace. Tests passes without it, we can remove it entirely to allow trailing whitespace in multiline strings or we can left it as it is to remove trailing whitespaces from strings.I'm also not sure about naming of the new functions.