Skip to content

content: add lessons 10 and 11#3

Merged
NathanLovato merged 21 commits into
mainfrom
lesson-10
Jan 24, 2022
Merged

content: add lessons 10 and 11#3
NathanLovato merged 21 commits into
mainfrom
lesson-10

Conversation

@cogwoz
Copy link
Copy Markdown
Contributor

@cogwoz cogwoz commented Dec 27, 2021

  • Add better delta visual example
  • Remove move_local_x() in examples as it already uses delta behind the scenes

I've combined lessons 10 and 11 into one pull request.

I'd have liked to add another practice to both lessons which used move_local_x(), but I couldn't get the tests to work by comparing Vector2.

@cogwoz cogwoz changed the title Lesson 10 content: add lessons 10, 11, and 12 Dec 27, 2021
@cogwoz cogwoz changed the title content: add lessons 10, 11, and 12 content: add lessons 10 and 11 Dec 27, 2021
@cogwoz cogwoz marked this pull request as ready for review December 27, 2021 18:44
@cogwoz cogwoz requested a review from NathanLovato December 27, 2021 18:44
Comment thread course/lesson-3-standing-on-shoulders-of-giants/ExampleRotateSprite.tscn Outdated
@Xananax
Copy link
Copy Markdown
Contributor

Xananax commented Jan 10, 2022

I found it hard to do something like code review; it was easier and faster to intervene directly on the content.

Please check the changes and see if you agree with them. I've mostly moved things around, as well as changed a few formulations that I deemed too complex for newcomers.

One functional change I've made is to have the delta examples display rotation and framerate, so the reader can more readily follow what is going on, but this is a quick hack and doesn't look good. If we decide to keep it, we probably have to make it look nicer.

I need to say I don't think the rotation works very well for the purposes of what we're trying to demonstrate. As exercises, it's fine, but as examples, rotation makes it really difficult to notice lack of smoothness, or to realize the distance jumped from frame to frame.

A linear movement on one axis would serve much better to understand how smooth/unsmooth movement can be with or without delta.

Reporting my proposal from the chat here:

I'd see for example a car on a straight line, duplicated 3 different times:

🚗 ------------------------------ normal
🚗 ------------------------------ choppy (constant distance per frame)
🚗 ------------------------------ choppy (using delta)
computer speed --o-------

The "normal" car constantly goes from left to right and then again.
Maybe the speed slider can be a toggle between "potatoe computer" "weak computer" and "normal computer"

Another proposition to show how delta works:
Making it so user can change delta, and show the 10 frames, as well as the car/character's position, all at once.

Something like an onion skin and regular static intervals drawn on the stage.

As the user changes delta to match the actual time delta of each frame, they can see each onion skin match up visually with the markers

@cogwoz
Copy link
Copy Markdown
Contributor Author

cogwoz commented Jan 11, 2022

I think the change in the delta example is a great idea. A straight line example would be better absolutely!

I'll make some changes and get your input again, thanks!

@NathanLovato
Copy link
Copy Markdown
Contributor

I'm facing a bug: I can't complete assignments in lesson 10. Even with the provided solution.

Also, the practices talk about slow movement, but on my computer, the provided argument of 0.05 to rotate leads to a fast rotation.


Regarding the delta example in lesson 11, it's confusing to me as it is. I think there shouldn't be a reference row but only a version with and without delta. Also, there's a lot of choppiness in the motion and it's hard to understand.

If you want to get across the idea of varying time deltas, I would recommend not doing it like this as right now, both with and without delta, it just looks like neither approach works. I think showing only the character overshooting the target is enough.

In general, I think it'll be easier for students if we try to show only one thing at a time. If you want to illustrate variations in delta, then I'd make a different visualization. Maybe a graph of the value over time, something like that.

@NathanLovato
Copy link
Copy Markdown
Contributor

Fixed conflicts and made assignments pass in lesson 10

@NathanLovato
Copy link
Copy Markdown
Contributor

I'm going to merge now to avoid more conflicts and open a task to improve the delta presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants