Skip to content

Fire bullet example (gen3) #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 1, 2022
Merged

Fire bullet example (gen3) #398

merged 23 commits into from
Nov 1, 2022

Conversation

@tristanbob
Copy link
Contributor

@tristanbob tristanbob commented Oct 21, 2022

This is used to test the new extension: GDevelopApp/GDevelop-extensions#642

@tristanbob tristanbob self-assigned this Oct 21, 2022
@tristanbob tristanbob requested a review from a team October 21, 2022 00:05
@tristanbob tristanbob added the 🔄 Example update An update for an existing example label Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Preview the game(s) changed or added in this Pull Request

This is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 34.4%, saving 344 bytes.

Filename Before After Improvement Visual comparison
examples/fire-bullet/assets/Treasure Chest_Closed.png 289 bytes 200 bytes -30.8% View diff
examples/fire-bullet/assets/Treasure Chest_Opening_1.png 380 bytes 233 bytes -38.7% View diff
examples/fire-bullet/assets/Treasure Chest_Opening_2.png 330 bytes 222 bytes -32.7% View diff

4412 images did not require optimisation.

@tristanbob tristanbob mentioned this pull request Oct 21, 2022
Merged
@tristanbob
Copy link
Contributor Author

tristanbob commented Nov 1, 2022

The extension is finished so I'm ready for a review of this game example.

D8H
D8H approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@D8H D8H left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it updates an existing example, I don't see any reason not to merge it, but this example contains a lot of unnecessary events. I think it should be made into a very simple example to avoid to confuse readers.

@tristanbob tristanbob merged commit ba097e8 into main Nov 1, 2022
@tristanbob tristanbob deleted the fire-bullet-example-gen3 branch November 1, 2022 16:57
@tristanbob
Copy link
Contributor Author

tristanbob commented Nov 1, 2022

As it updates an existing example, I don't see any reason not to merge it, but this example contains a lot of unnecessary events. I think it should be made into a very simple example to avoid to confuse readers.

Thanks @D8H! Are you talking about player and enemy movement? I want a minimal "game" experience that people could use to imagine this extension in their game. (I removed perhaps ~90% of the original game code.)

@D8H
Copy link
Contributor

D8H commented Nov 1, 2022 •
edited
Loading

Oh, ok, the number of event groups seems a lot but I didn't really look into them.
Maybe the 1st scene could be removed?

@tristanbob
Copy link
Contributor Author

tristanbob commented Nov 2, 2022

Oh, ok, the number of event groups seems a lot but I didn't really look into them. Maybe the 1st scene could be removed?

Next time I make a PR for this example (gen 4) I will remove the first scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D8H D8H D8H approved these changes

Assignees

@tristanbob tristanbob

Labels

🔄 Example update An update for an existing example

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tristanbob @D8H