Linux installer: small improvements #116
Conversation
- silence zenity - usable without dbus - correct shebang - detect python3 (with some from __future__ we could make it work with python2 but is this necessary?)
|
You've sent the pull request against master. Do you want this to be part of the 2.0.x series? Then it should go into branch release_2_0 instead. TBH, when I read "not tested very thoroughly" maybe it's better to merge it by a future 2.0.1 time and not during our short beta phase before going to prod...? |
|
That's why it's not against release_2_0 but master. I can also make it to apply against 2.0 -- the only difference should be the #114 shebang-line. I don't know how and where to test this without a large audience and many different distros. On my 2 test distros (Debian and Ubuntu) and some mockup scenarios it was working fine. I don't know how much this was tested before as the missing shebang was a real bummer.... |
|
These things are rather thoroguhly tested by @twoln - he has many distros on his list. But then he is so knowledgable that he probably always typed in "python ..." and didn't realise the shebang issue. |
| if q.returncode == 0: | ||
| self.graphics = 'zenity' | ||
| if not debug_on: | ||
| self.stderr_redir=subprocess.DEVNULL |
There was a problem hiding this comment.
DEVNULL exists since 3.3. So no 2.7 support. We should define which python versions we will support.
There was a problem hiding this comment.
Whoops. Good catch, thank you.
There was a problem hiding this comment.
The way I read these modification it looks like dropping python 2.7 altogether. As I said in the other thread, I would be reluctant do do that at this stage. Do you really think that the issues we may now have are so bad? I did not observe them in my tests.
Fixing the problem with zenity output is great, of course.
There was a problem hiding this comment.
It's easy to change it for py2-support if we decide to want it -- we could just open /dev/null directly or pipe it somewhere else.
|
|
||
| def run_installer(): | ||
| global debug_on | ||
| if sys.version_info.major < 3: |
There was a problem hiding this comment.
Maybe, we should also test older python3 versions with sys.version_info.minor?
There was a problem hiding this comment.
If you use features from later versions, definitely...
|
I think all of these have been implemented. OK to close? |
5 participants
from __future__we could make it work withpython2 but is this necessary?)
This is not tested very thorowly.