feat: Add freeOnDevice calls on Wave Propagation Solvers #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb15aae.
…s://github.com/GEOS-DEV/GEOS into feature/AddFreeOnDeviceInWavePropagationSolver
Collaborator
|
@acitrain is it still active? |
Contributor
Author
yes it should.. @jiemeng-total are you going to use this pull request for the free on device etc stuf? |
jiemeng-total
requested review from
CusiniM,
corbett5 and
wrtobin
as code owners
sframba
changed the title
sframba
added
ci: run CUDA builds
sframba
approved these changes
Oct 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2610 +/- ##
===========================================
+ Coverage 56.40% 56.41% +0.01%
===========================================
Files 1065 1065
Lines 90331 90396 +65
===========================================
+ Hits 50951 51001 +50
- Misses 39380 39395 +15 ☔ View full report in Codecov by Sentry. |
danielemoretto44
pushed a commit
that referenced
this pull request
Sep 22, 2025
* Add freeOnDevice calls * Update LvArray submodule * Revert "Update LvArray submodule" This reverts commit bb15aae. * Update LvArray submodule * add FreeOnDevice for Array * adding freeOnDevice for wavePropagation sovlers * add freeOnDevice function to AcousticFirstOrderWaveEquationSEM * udpate LvArray version * added freeOnDevice calls to all other wave solvers * uncrustify --------- Co-authored-by: Stefano Frambati <stefano.frambati@totalenergies.com> Co-authored-by: Jie Meng <jie.meng@total.com> Co-authored-by: j0405284 <stefano.frambati@total.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the call to free some array from GPU memory using freeOnDevice method added in the following LvArray PR :
GEOS-DEV/LvArray#298