Skip to content

fix: Bug fix for residual computation #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2024
Merged

fix: Bug fix for residual computation #3399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89cbfd
fix: Bug fix for residual computation
paveltomin Oct 15, 2024
2ebe1f0
Merge branch 'develop' into pt/residualnorm-bugfix
paveltomin Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreComponents/physicsSolvers/fluidFlow/ThermalCompositionalMultiphaseBaseKernels.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,15 +911,15 @@
// step 2: volume residual

real64 const valVol = LvArray::math::abs( m_localResidual[stack.localRow + m_numComponents] ) / volumeNormalizer;
if( valVol > stack.localValue[0] )
if( valVol > stack.localValue[1] )

Check warning on line 914 in src/coreComponents/physicsSolvers/fluidFlow/ThermalCompositionalMultiphaseBaseKernels.hpp

View check run for this annotation

Codecov / codecov/patch

src/coreComponents/physicsSolvers/fluidFlow/ThermalCompositionalMultiphaseBaseKernels.hpp#L914 

Added line #L914 was not covered by tests
{
stack.localValue[1] = valVol;
}

// step 3: energy residual

real64 const valEnergy = LvArray::math::abs( m_localResidual[stack.localRow + m_numComponents + 1] ) / energyNormalizer;
if( valEnergy > stack.localValue[1] )
if( valEnergy > stack.localValue[2] )

Check warning on line 922 in src/coreComponents/physicsSolvers/fluidFlow/ThermalCompositionalMultiphaseBaseKernels.hpp

View check run for this annotation

Codecov / codecov/patch

src/coreComponents/physicsSolvers/fluidFlow/ThermalCompositionalMultiphaseBaseKernels.hpp#L922 

Added line #L922 was not covered by tests
{
stack.localValue[2] = valEnergy;
}
Expand Down