Skip to content

fix: Crashes in some wave propagation cases after some varaibles are free'd on device #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: Crashes in some wave propagation cases after some varaibles are free'd on device #3409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...avePropagation/sem/acoustic/firstOrderEqn/isotropic/AcousticFirstOrderWaveEquationSEM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ void AcousticFirstOrderWaveEquationSEM::precomputeSourceAndReceiverTerm( MeshLev
baseMesh.getNodeManager().elementList().toView().freeOnDevice();
baseMesh.getFaceManager().nodeList().toView().freeOnDevice();
baseMesh.getNodeManager().referencePosition().freeOnDevice();
m_sourceCoordinates.freeOnDevice();
m_receiverCoordinates.freeOnDevice();
facesToNodes.freeOnDevice();
nodesToElements.freeOnDevice();
}
Expand Down
2 changes: 0 additions & 2 deletions ...rs/wavePropagation/sem/acoustic/secondOrderEqn/anisotropic/AcousticVTIWaveEquationSEM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@ void AcousticVTIWaveEquationSEM::precomputeSourceAndReceiverTerm( MeshLevel & ba
baseMesh.getNodeManager().elementList().toView().freeOnDevice();
baseMesh.getFaceManager().nodeList().toView().freeOnDevice();
baseMesh.getNodeManager().referencePosition().freeOnDevice();
m_sourceCoordinates.freeOnDevice();
m_receiverCoordinates.freeOnDevice();
facesToNodes.freeOnDevice();
nodesToElements.freeOnDevice();
}
Expand Down
3 changes: 1 addition & 2 deletions ...Solvers/wavePropagation/sem/acoustic/secondOrderEqn/isotropic/AcousticWaveEquationSEM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ void AcousticWaveEquationSEM::precomputeSourceAndReceiverTerm( MeshLevel & baseM
baseMesh.getNodeManager().elementList().toView().freeOnDevice();
baseMesh.getFaceManager().nodeList().toView().freeOnDevice();
baseMesh.getNodeManager().referencePosition().freeOnDevice();
m_sourceCoordinates.freeOnDevice();
m_receiverCoordinates.freeOnDevice();
facesToNodes.freeOnDevice();
nodesToElements.freeOnDevice();
}
Expand Down Expand Up @@ -1081,6 +1079,7 @@ void AcousticWaveEquationSEM::synchronizeUnknowns( real64 const & time_n,
acousticfields::AuxiliaryVar4PML::key() } );
}


CommunicationTools & syncFields = CommunicationTools::getInstance();
syncFields.synchronizeFields( fieldsToBeSync,
mesh,
Expand Down
2 changes: 0 additions & 2 deletions .../wavePropagation/sem/elastic/firstOrderEqn/isotropic/ElasticFirstOrderWaveEquationSEM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,6 @@ void ElasticFirstOrderWaveEquationSEM::precomputeSourceAndReceiverTerm( MeshLeve
baseMesh.getNodeManager().elementList().toView().freeOnDevice();
baseMesh.getFaceManager().nodeList().toView().freeOnDevice();
baseMesh.getNodeManager().referencePosition().freeOnDevice();
m_sourceCoordinates.freeOnDevice();
m_receiverCoordinates.freeOnDevice();
facesToNodes.freeOnDevice();
nodesToElements.freeOnDevice();
}
Expand Down
2 changes: 0 additions & 2 deletions ...csSolvers/wavePropagation/sem/elastic/secondOrderEqn/isotropic/ElasticWaveEquationSEM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,6 @@ void ElasticWaveEquationSEM::precomputeSourceAndReceiverTerm( MeshLevel & baseMe
baseMesh.getNodeManager().elementList().toView().freeOnDevice();
baseMesh.getFaceManager().nodeList().toView().freeOnDevice();
baseMesh.getNodeManager().referencePosition().freeOnDevice();
m_sourceCoordinates.freeOnDevice();
m_receiverCoordinates.freeOnDevice();
facesToNodes.freeOnDevice();
nodesToElements.freeOnDevice();
}
Expand Down