-
Notifications
You must be signed in to change notification settings - Fork 97
fix: Standardisation of incorrect sub-group creation errors #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added context to know the erroneous parent & exposed a unique error reference for other classes.
…gionManager define possible child keys
|
looks like there are some changes from |
|
@wrtobin half mistake, half in place pratices in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3418 +/- ##
===========================================
+ Coverage 56.79% 56.82% +0.02%
===========================================
Files 1154 1154
Lines 100074 100079 +5
===========================================
+ Hits 56836 56867 +31
+ Misses 43238 43212 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* 🐛 bugfix: Proper error when detecting child that is not a xml elements * 💄 small error edit for uniformisation * 💡 Added note on all empty createChild() * Re rewrite of ObjectCatalog errors for bad children : Added context to know the erroneous parent & exposed a unique error reference for other classes. * added ability to get context from a cpp source file (typically for tests) * Updated ElementRegionManager error message + refactored how ElementRegionManager define possible child keys * Updated WellSolverBase error message * ⚰️ wrong & dead code removal * 📝 object catalog factory docs update * Prefering more contextualized catalog error over custom ones * Updated WellGeneratorBase error message * standardize group name processing * regex validation fail message improvement * 📝 Group::processInputName docs * 📝 doc add & updates * 📝 doc update * std::string -> string --------- Co-authored-by: Pavel Tomin <paveltomin@users.noreply.github.com>
This PR aim to standardise the behaviour & log message when user attempt to create in a given node:
Grouptype name request inGroup::createChild())For instance, before this PR, entering raw text in a
<ElementRegions>resulted in a misleading message:We would now have:
If a
Grouptype would need this kind of sub-content later, we would have to manage this data, and silence this error for the case it would be allowed.For instance, before this PR, adding a wrongly spelled
<Perforation>, or any unexpected name, in a<InternalWell>a resulted in:We would now have:
Previously, error of this kind were not always managed properly. Also, various
Grouptypes messages were not standardized nor indicating available sub-type names.This PR also improve how wrong character are underlined:
It was broken for some cases by the PR #3403, so I fixed that and also improved it by underlining the (first) whole sequence of wrong characters.