feat: --validate-input command line option#3728
Merged
Conversation
Contributor
|
This is a very useful feature. Can we add it somewhere in QuickStart.rst. |
Contributor
Author
|
@dkachuma |
MelReyCG
added
ci: run CUDA builds
MelReyCG
changed the title
validate-input command line optionvalidate-input command line option
paveltomin
requested review from
CusiniM,
OmarDuran,
castelletto1,
dkachuma,
herve-gross,
jhuang2601 and
paveltomin
as code owners
paveltomin
approved these changes
Aug 4, 2025
castelletto1
approved these changes
Aug 4, 2025
jhuang2601
approved these changes
Aug 4, 2025
Contributor
jhuang2601
left a comment
jhuang2601
left a comment
There was a problem hiding this comment.
This feature is incredibly helpful.
Thanks for making it available.
herve-gross
approved these changes
Aug 4, 2025
dkachuma
approved these changes
Aug 6, 2025
MelReyCG
changed the title
validate-input command line option--validate-input command line option
rrsettgast
reviewed
Aug 18, 2025
Member
rrsettgast
left a comment
rrsettgast
left a comment
There was a problem hiding this comment.
@MelReyCG I am missing where geos would terminate if onlyValidateInput==true. Can you point it out to me?
MelReyCG
commented
Aug 19, 2025
Comment on lines
+180
to
+185
| if( getCommandLineOptions().onlyValidateInput ) | ||
| { | ||
| m_state = State::COMPLETED; | ||
| GEOS_LOG( "Input validation completed, terminating GEOS..." ); | ||
| } | ||
| else if( !getProblemManager().runSimulation() ) |
Contributor
Author
There was a problem hiding this comment.
Sure, here it is ^
We set the GEOS state to completed and prevent it to run the simulation l.185. I can avoid using else if here if that is not clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to allow to launch GEOS to only run the loading phase, skipping any simulation and validating that GEOS can load a case without encountering any issue.
To do so, here is the proposed new command line option:
It also updates documentation accordingly.
This PR also fix the GEOS behavior when no command line argument are given (GEOS would throw errors and stacktrace, contrary to what is stated in the current documentation), and update the current "empty command line params" output in our docs.