feat: Improve error message when targetting wrong solver#3882
Merged
feat: Improve error message when targetting wrong solver#3882
Conversation
paveltomin
reviewed
Oct 24, 2025
src/coreComponents/physicsSolvers/multiphysics/CoupledSolver.hpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Oct 24, 2025
src/coreComponents/physicsSolvers/multiphysics/CoupledSolver.hpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Oct 27, 2025
src/coreComponents/physicsSolvers/multiphysics/CoupledSolver.hpp
Outdated
Show resolved
Hide resolved
dkachuma
approved these changes
Oct 27, 2025
src/coreComponents/physicsSolvers/multiphysics/CoupledSolver.hpp
Outdated
Show resolved
Hide resolved
herve-gross
approved these changes
Oct 27, 2025
paveltomin
reviewed
Oct 27, 2025
src/coreComponents/physicsSolvers/multiphysics/CoupledSolver.hpp
Outdated
Show resolved
Hide resolved
paveltomin
approved these changes
Oct 27, 2025
MelReyCG
reviewed
Oct 27, 2025
| { | ||
| std::ostringstream errorMessage; | ||
| errorMessage << GEOS_FMT( "{}: Could not find solver named '{}'.\n", | ||
| getDataContext(), solverName ); |
Contributor
There was a problem hiding this comment.
To target the solver attribute (xml line):
Suggested change
| getDataContext(), solverName ); | |
| getWrapperDataContext( SolverType::coupledSolverAttributePrefix() ), | |
| solverName ); |
then you can remove the string const & solverType parameter from throwSolversNotFound()
…-indicative-solver-ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aim to improve the error message when a coupled solver target wrong solver
Before :
After :
** StackTrace of 7 frames **`
if we don"t have any flow solver we get :