Skip to content

fix: MPI runs for smoke tests with surfaceGenerator#4068

Open
jhuang2601 wants to merge 6 commits into
developfrom
fix/jhuang/MPI_smokeTests
Open

fix: MPI runs for smoke tests with surfaceGenerator#4068
jhuang2601 wants to merge 6 commits into
developfrom
fix/jhuang/MPI_smokeTests

Conversation

@jhuang2601
Copy link
Copy Markdown
Contributor

@jhuang2601 jhuang2601 commented May 28, 2026

Another attempt to fix CI failures for MPI runs of two newly added smoke tests using surfaceGenerator, see PR#4062

The original code is functionally correct but generates results ordering which is not strictly deterministic across runs.

  • Enable mpiCommOrder="1"in the XML inputs
  • Replace pointer-based ordering of elemLocations with a comparator using deterministic region/subregion indices

@jhuang2601 jhuang2601 requested a review from castelletto1 as a code owner May 28, 2026 21:25
@jhuang2601 jhuang2601 requested a review from bd713 May 28, 2026 21:26
@jhuang2601 jhuang2601 self-assigned this May 28, 2026
@jhuang2601 jhuang2601 added type: bug Something isn't working ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs flag: requires rebaseline Requires rebaseline branch in integratedTests labels May 28, 2026
@jhuang2601 jhuang2601 requested a review from OmarDuran May 29, 2026 13:53
@bd713 bd713 requested a review from rrsettgast as a code owner May 29, 2026 14:43
@rrsettgast
Copy link
Copy Markdown
Contributor

@jhuang2601 was mpiCommOrder="1" insufficient to solve the ordering issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants