-
Notifications
You must be signed in to change notification settings - Fork 0
ci: Add testing for the integration of geosPythonPackages in GEOS #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in GEOS is modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good though can you set up 2 dummy PR to your PR that check if the workflow is going as planned ?
REQUIRES_GEOS_TEST=false | ||
AFFECTED_PACKAGES="" | ||
for file in $CHANGED_FILES; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if some files req integration and some other doesn't ? IIUC now we are in "if any" behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the logic right here is if any file of one these folders is modified, test-geos-integration is mandatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
Closes #107 and replaces #121 by not using cross-repository implementation.