Skip to content

Conversation

alexbenedicto
Copy link
Collaborator

Closes #107 and replaces #121 by not using cross-repository implementation.

@alexbenedicto alexbenedicto added the test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI label Sep 24, 2025
@alexbenedicto alexbenedicto marked this pull request as ready for review October 10, 2025 18:24
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good though can you set up 2 dummy PR to your PR that check if the workflow is going as planned ?

REQUIRES_GEOS_TEST=false
AFFECTED_PACKAGES=""
for file in $CHANGED_FILES; do
Copy link
Contributor

@jafranc jafranc Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if some files req integration and some other doesn't ? IIUC now we are in "if any" behavior

Copy link
Collaborator Author

@alexbenedicto alexbenedicto Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the logic right here is if any file of one these folders is modified, test-geos-integration is mandatory

@jafranc
Copy link
Contributor

jafranc commented Oct 14, 2025

It looks good though can you set up 2 dummy PR to your PR that check if the workflow is going as planned ?

Done in closed #152 and #154

All good ! Great work !!

@alexbenedicto alexbenedicto requested a review from jafranc October 14, 2025 23:13
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

@paloma-martinez paloma-martinez merged commit d4ced19 into main Oct 15, 2025
48 checks passed
@paloma-martinez paloma-martinez deleted the benedicto/ci/test-integration-in-geos branch October 15, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GEOS main repository testing

3 participants