feat: add a mesh‑doctor action to compute a mesh’s Euler characteristic#239
Merged
feat: add a mesh‑doctor action to compute a mesh’s Euler characteristic#239
Conversation
jafranc
added
the
test-geos-integration
jafranc
approved these changes
Mar 4, 2026
Contributor
Author
There was a problem hiding this comment.
mypy was requesting this modification due to the function potentially returning None.
Not sure why it wasn't picked up by the CI earlier.
| point_ids = tuple( sorted( [ face.GetPointId( j ) for j in range( num_pts ) ] ) ) | ||
| face_list.append( point_ids ) | ||
|
|
||
| # Use numpy unique for deduplication (faster than set) |
Contributor
Author
There was a problem hiding this comment.
~20% on the case I used.
Collaborator
There was a problem hiding this comment.
Wow, that certainly scale as number of duplicates, where sorting and non-hashing is more efficient. But still impressive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.