Skip to content

Conversation

@klevzoff
Copy link
Contributor

@klevzoff klevzoff commented Aug 6, 2025

Looks like Scotch config in #310 resulted in some non-deterministic behavior which causes one integrated test to constantly fail baseline checks in GEOS-DEV/GEOS#2427. This was partly due to a bug in Scotch CMake that was recently fixed. To get fully reproducible behavior between runs, one must configure with SCOTCH_DETERMINISTIC=FULL cmake flag.

This PR updates Scotch to latest v7.0.8 that includes the fix and updates Spack package recipes to configure Scotch correctly. Note that this fix does not yet exist in upstream Spack, so my approach may differ from what package maintainers eventually decide on.

Once this is merged, GEOS-DEV/GEOS#2427 will be updated to a new GEOS_TPL_TAG.

@klevzoff klevzoff self-assigned this Aug 6, 2025
@klevzoff klevzoff force-pushed the feature/klevzoff/scotch-cmake-2 branch from f38b50a to 2e31722 Compare August 6, 2025 07:09
@klevzoff
Copy link
Contributor Author

klevzoff commented Aug 6, 2025

Had some problems with system-installed flex version on Rocky linux, so went nuclear in last two commits and removed system installed flex/bison from all images 😅 Scotch is quite finicky when it comes to flex versions, so trying to just let spack install the right version. Could've done this just for two problematic images instead, but let's see if this works, might save some future headaches.

@klevzoff klevzoff force-pushed the feature/klevzoff/scotch-cmake-2 branch from a1b42bb to 3046faf Compare August 8, 2025 16:44
@OmarDuran
Copy link
Contributor

Had some problems with system-installed flex version on Rocky linux, so went nuclear in last two commits and removed system installed flex/bison from all images 😅 Scotch is quite finicky when it comes to flex versions, so trying to just let spack install the right version. Could've done this just for two problematic images instead, but let's see if this works, might save some future headaches.

I had similar issues with system-installed flex version on macOS. These changes make a lot of sense to me.

@klevzoff klevzoff force-pushed the feature/klevzoff/scotch-cmake-2 branch from 3046faf to e865fbc Compare August 9, 2025 04:34
@klevzoff klevzoff merged commit 5e42b20 into master Aug 14, 2025
12 checks passed
Bubusch added a commit that referenced this pull request Aug 25, 2025
@bmhan12 bmhan12 mentioned this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants