Migrate packed-time calls away from legacy MAPL umbrella#419
Merged
Conversation
…GOCART #417) Replace legacy subroutine-form MAPL_PackTime calls in DU2G, SU2G, and CA2G gridded components with the new function-form constructors from MAPL_PackedTimeMod (MAPL #4811 bridge module): call MAPL_PackTime(nymd, yy, mm, dd) -> nymd = MAPL_PackedDateCreate(yy, mm, dd) call MAPL_PackTime(nhms, hh, mn, ss) -> nhms = MAPL_PackedTimeCreate(hh, mn, ss)
Inline HHMMSS packed-integer arithmetic directly into ESMF_TimeIntervalSet, eliminating the dependency on the legacy MAPL2 MAPL_UnpackTime subroutine.
tclune
added
0 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DU2G_GridCompMod.F90,SU2G_GridCompMod.F90,CA2G_GridCompMod.F90: replaceMAPL_PackTimecalls withMAPL_PackedDateCreate/MAPL_PackedTimeCreatefromMAPL_PackedTimeModReplenishAlarm.F90: removeMAPL_UnpackTime; inline HHMMSS arithmetic directly intoESMF_TimeIntervalSetPart of GEOS-ESM/MAPL#4811 — enables deletion of legacy packed-time symbols from
Base_Base.Closes #417