Skip to content

Don't run GCM build on trivial PRs#446

Merged
mathomp4 merged 1 commit into
developfrom
feature/mathomp4/no-gcm-build-on-trivial
Jun 22, 2020
Merged

Don't run GCM build on trivial PRs#446
mathomp4 merged 1 commit into
developfrom
feature/mathomp4/no-gcm-build-on-trivial

Conversation

@mathomp4
Copy link
Copy Markdown
Member

Description

This PR should update the CI such that PRs labeled with "0 diff trivial" will not need a full build of GEOSgcm, but just do the cheaper (though perhaps not needed) MAPL build and tests. The hope is that people will only label trivial changes that are trivial, though this could back fire.

Motivation and Context

The GEOSgcm test is expensive. Until we can run these builds at make -j20 say on our own runners, it's probably best if trivial PRs don't need that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jun 22, 2020
@mathomp4 mathomp4 requested a review from a team as a code owner June 22, 2020 17:04
@mathomp4 mathomp4 self-assigned this Jun 22, 2020
@mathomp4 mathomp4 merged commit afb4616 into develop Jun 22, 2020
@mathomp4 mathomp4 deleted the feature/mathomp4/no-gcm-build-on-trivial branch June 22, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants