Add TimeAccumulate with unit tests.#4869
Merged
Merged
Conversation
darianboggs
added
🎁 New Feature
tclune
reviewed
May 12, 2026
tclune
reviewed
May 12, 2026
tclune
reviewed
May 12, 2026
tclune
requested changes
May 12, 2026
Collaborator
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
One change and one important question (inline comments)
…-ESM/MAPL into feature/wdboggs/add_time_accumulate
…t through MAPL umbrella (#4882) * Extend mapl3g_FileIO WRITE_PARALLEL with scalar/1d integer and real overloads (refs #4879) * Move FileIOSharedMod and NCIOMod to base3g/, re-export through MAPL umbrella (refs #4874, #4879) - Move FileIOShared.F90 and NCIO.F90 from base/ to base3g/ with temporary internal module names (mapl_FileIOShared, mapl_NCIO) - Leave thin compatibility wrappers in base/ under original module names (FileIOSharedMod, NCIOMod) so existing callers are unaffected - Copy write_parallel.H and read_parallel.H to base3g/include/ - Update base3g/CMakeLists.txt with new sources and dependencies - Re-export ArrDescr, ArrDescrInit, ArrDescrSet, MAPL_VarRead, MAPL_VarWrite, MAPL_NCIOGetFileType, MAPL_IOGetNonDimVars, MAPL_IOCountNonDimVars, MAPL_IOChangeRes, MAPL_IOCountLevels through mapl_base3g so they are available via 'use MAPL' * Move MAPL_LocStreamMod to base3g/ (module mapl_LocStreamMod_impl); leave thin wrapper in base/ (refs #4874)
…amMod (closes #4874) (#4883) * Remove base/ thin wrappers for FileIOSharedMod, NCIOMod, MAPL_LocStreamMod; move c_mapl_locstream_F.c to base3g/ (closes #4874) * Drop NCIOMod and MAPL_LocStreamMod from MAPL2 — symbols no longer needed there (refs #4874) * Add mapl2-migration skill documenting iterative PR process for base/ to base3g/ migrations * Update mapl2-migration skill: always rebase onto target branch before pushing/opening a PR * Remove orphaned write_parallel.H and read_parallel.H from base/ (now live in base3g/include/) (refs #4874) * Remove orphaned GetPointer.H from base/ — no longer used (refs #4874) * Remove orphaned GetFieldArray.H from base/ — no longer used (refs #4874)
…-ESM/MAPL into feature/wdboggs/add_time_accumulate
tclune
previously approved these changes
May 14, 2026
darianboggs
dismissed
tclune’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Statistic computations were implemented through FrequencyAspect and the associated transforms previously. Now the computations are handled with StatisticsGridComp. FrequencyAspect and the associated transforms were removed in a previous PR. One statistic handled by FrequencyAspect, accumulation (summation) in time, was not implemented with StatisticGridComp. This PR adds a new type derived from AbstractStatisticsGridComp called TimeAccumulate to calculate the missing accumulation statistic. The PR includes unit tests of the new type. Since the procedures are bound to TimeAccumulate type, the unit tests mirror the tests individually. An integration test requires creating a TimeAccumulate object, and it is out of the scope of this PR.
Related Issue