Skip to content

MAPL: fix vector component naming lifecycle#4946

Merged
pchakraborty merged 2 commits into
developfrom
bugfix/pchakrab/fix-vector-fields
May 20, 2026
Merged

MAPL: fix vector component naming lifecycle#4946
pchakraborty merged 2 commits into
developfrom
bugfix/pchakrab/fix-vector-fields

Conversation

@pchakraborty
Copy link
Copy Markdown
Contributor

Summary

Fix vector component naming flow so VectorClassAspect consistently uses resolved component names.

Changes

  • In VariableSpec, pass resolved vector_component_names into VectorClassAspect instead of this%vector_component_names.
  • In VectorClassAspect create path, set each component field name immediately after payload retrieval using this%short_names.
  • Remove deferred component renaming from add_to_state.

Why

This prevents incorrect or missing component names when fallback/default vector names are used and keeps naming behavior consistent across lifecycle stages.

Testing

  • Verified staged diff for VariableSpec and VectorClassAspect changes.
  • No full build/test run performed in this step.

@pchakraborty pchakraborty requested a review from a team as a code owner May 20, 2026 11:45
@pchakraborty pchakraborty self-assigned this May 20, 2026
@pchakraborty pchakraborty added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels May 20, 2026
tclune
tclune previously approved these changes May 20, 2026
@pchakraborty pchakraborty merged commit 4564272 into develop May 20, 2026
30 checks passed
@pchakraborty pchakraborty deleted the bugfix/pchakrab/fix-vector-fields branch May 20, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants