refactor: use API to fetch Hp index#52
Merged
sahiljhawar merged 2 commits intoGFZ:mainfrom Feb 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Hp GFZ data source to fetch Hp index data from the GFZ JSON API instead of downloading text files via FTP.
Changes:
- Replace FTP-based downloads with
requests.get()calls to the GFZ JSON API and persist responses as temporary JSON. - Update
_process_single_fileto parse the JSON response into a pandas DataFrame. - Adjust and extend tests to reflect the new download and processing flow, including URL construction expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
swvo/io/hp/gfz.py |
Switches Hp downloads from FTP to GFZ JSON API and updates parsing accordingly. |
tests/io/hp/test_hp.py |
Updates unit tests for the new JSON/API-based implementation and adds URL-construction coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.