add pnp error handling and test #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gun-yu
commented
Nov 1, 2025
gun-yu
commented
Nov 1, 2025
gun-yu
commented
Nov 1, 2025
GGomez99
approved these changes
Nov 1, 2025
GGomez99
reviewed
Nov 2, 2025
internal/module/resolver.go
Outdated
| if ok { | ||
| typeRoots = pnpTypeRoots | ||
| } | ||
| typeRoots, fromConfig = pnpApi.AppendPnpTypeRoots(typeRoots, compilerOptions.GetBaseDirFromOptions(r.host.GetCurrentDirectory()), false) |
There was a problem hiding this comment.
I'm sorry if I wasn't clear, but you need to pass the fromConfig as the third argument too:
Suggested change
| typeRoots, fromConfig = pnpApi.AppendPnpTypeRoots(typeRoots, compilerOptions.GetBaseDirFromOptions(r.host.GetCurrentDirectory()), false) | |
| typeRoots, fromConfig = pnpApi.AppendPnpTypeRoots(typeRoots, compilerOptions.GetBaseDirFromOptions(r.host.GetCurrentDirectory()), fromConfig) |
There was a problem hiding this comment.
Thank you for taking the time to check it! abbd1c3
GGomez99
reviewed
Nov 2, 2025
GGomez99
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added tests and standardized the error messages to align with the conventions in TypeScript and Go.
I also made some minor implementation updates, which I’ll explain in the comments.