Skip to content

more robust multipolygon geometry building with invalid outer rings#185

Merged
mcauer merged 7 commits into
masterfrom
bugfix-179-multipolygongeometry-invalidouters
Jul 5, 2019
Merged

more robust multipolygon geometry building with invalid outer rings#185
mcauer merged 7 commits into
masterfrom
bugfix-179-multipolygongeometry-invalidouters

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented May 31, 2019

fixes #179 and introduce an optimized code path for single-outer-multipolygons, and introduces a temporary r-tree to speed up building of actual multipolygons (with multiple outer rings).

Changes proposed in this pull request:

Type of change

Please delete if not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • Performance optimization

Corresponding issue

Closes #179

Checklist

@tyrasd tyrasd added bug Something isn't working as expected performance Performance optimizations, bottlenecks of the current pipeline, etc. labels May 31, 2019
fixes #179

also, introduce an optimized path for single outer multipolygons. and use a temporary r-tree to speed up building of actual multipolygons (with multiple outer rings).
@tyrasd tyrasd force-pushed the bugfix-179-multipolygongeometry-invalidouters branch from 4d341b3 to 910c294 Compare May 31, 2019 14:32
@tyrasd tyrasd requested a review from mcauer July 5, 2019 12:20
Copy link
Copy Markdown
Member

@mcauer mcauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcauer mcauer merged commit 4fc4d7f into master Jul 5, 2019
@mcauer mcauer deleted the bugfix-179-multipolygongeometry-invalidouters branch July 5, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected performance Performance optimizations, bottlenecks of the current pipeline, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled TopologyException when creating polygons from relations

2 participants