Skip to content

improve sql querying of tags, fixes #221#222

Merged
tyrasd merged 1 commit into
masterfrom
issue-221
Apr 6, 2020
Merged

improve sql querying of tags, fixes #221#222
tyrasd merged 1 commit into
masterfrom
issue-221

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Apr 4, 2020

  • prepare statements in constructor and reuse them
  • make the class autoclosable
  • close resultsets after they are used
  • fix checkstyle warnings

Checklist

* prepare statements in constructor and reuse them
* make the class autoclosable
* close resultsets after they are used
* fix checkstyle warnings
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Apr 4, 2020
@tyrasd tyrasd requested a review from rtroilo April 4, 2020 09:27
Copy link
Copy Markdown
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@tyrasd tyrasd merged commit a6e1852 into master Apr 6, 2020
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Apr 6, 2020
@tyrasd tyrasd deleted the issue-221 branch April 6, 2020 10:23
@tyrasd tyrasd restored the issue-221 branch April 6, 2020 10:39
@tyrasd tyrasd added the performance Performance optimizations, bottlenecks of the current pipeline, etc. label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance optimizations, bottlenecks of the current pipeline, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants