integrate ohsome filter

[tyrasd]

see #302

New or changed dependencies:

• dropped filter library, integrated here directly

Checklist

• My code follows the code-style rules and I have checked on the static analyses and benchmark (if applicable) results
• I have commented my code
• I have written javadoc (required for public methods)
• I have added sufficient unit tests
• I have made corresponding changes to the documentation see integrate ohsome filter #306 (comment)
• I have updated the CHANGELOG.md
• I have adjusted the examples and benchmark if necessary see integrate ohsome filter #306 (comment)

[tyrasd]

documentation, examples (and benchmarks?) will be updated in a separate PR

[joker234]

Open ToDo:

• fix "ohsome filter"

  oshdb/oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapReducer.java

  Line 2073 in 0f50415

  * Performs optimizations when filtering by an "ohsome filter" expression.

• missing @Deprecated?

  oshdb/oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapAggregator.java

  Line 371 in 0f50415

  public MapAggregator<U, X> osmTag(String key, Pattern valuePattern) {

• missing @Deprecated?

  oshdb/oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapReducer.java

  Line 599 in 0f50415

  public MapReducer<X> osmTag(String key, Pattern valuePattern) {

• change deprecation reference to new filter for all where(…) functions? This function and the following:

  oshdb/oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapReducerSettings.java

  Line 149 in 0f50415

  default M where(SerializablePredicate<OSMEntity> f) {

[joker234]

We don't want to keep the ohsome-filter Changelog, correct? Removed in c15e945

[tyrasd]

We don't want to keep the ohsome-filter Changelog, correct? Removed in c15e945

not really – it's still available in the original repository for reference

[joker234]

General comment: The review only included all files outside of /oshdb-filter and all changes in /oshdb-filter between 633bdcb and 0f50415 (current integrate-ohsome-filter). The changes before this commit are not reviewed as they were part of the old repository already.

[tyrasd]

missing @deprecated? [x2]

no, because the oshdb-filter doesn't have an equivalent for the String key, Pattern valuePattern case at the moment. see https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/libs/ohsome-filter/-/issues/11

[tyrasd]

change deprecation reference to new filter for all where(…) functions?

ui, I totally forgot these still exist. I think it's time to drop them with 0.7, but let's do that in a separate PR