make sure Filter predicates are always serializable#353
Merged
Conversation
783c0b4 to
be92298
Compare
creates a copy of the existing SerializablePredicate class in order to avoid a circular dependency.
be92298 to
e87c88b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes sure users don't have to manually make supplied lambdas serializable when using
Filter.by*.Currently (0.6.*) users need to do this workaround when executing a query with a filter on ignite:
After this fix, this should be sufficient:
This PR creates a local copy of the existing
SerializablePredicateclass as a an inner interface of theFilterclass in order to avoid a circular dependency between theoshdb-filterandoshdb-apimodules.Checklist
I have commented my codeI have added sufficient unit testsI have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository