Skip to content

🧹 code style fixes#374

Merged
rtroilo merged 43 commits into
masterfrom
checkstyle-oshdb-api
May 7, 2021
Merged

🧹 code style fixes#374
rtroilo merged 43 commits into
masterfrom
checkstyle-oshdb-api

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Apr 29, 2021

global code style clean up 🧹

Checklist

@tyrasd tyrasd added the code quality Related to our standards for 'good' code label Apr 29, 2021
@tyrasd tyrasd requested a review from rtroilo April 29, 2021 15:29
@tyrasd tyrasd changed the title code style improvements [oshdb-api] [oshdb-util] code style fixes (indents + misc) Apr 29, 2021
@tyrasd tyrasd force-pushed the checkstyle-oshdb-api branch from f01bbb9 to 2060990 Compare April 29, 2021 15:34
@tyrasd tyrasd changed the title [oshdb-api] [oshdb-util] code style fixes (indents + misc) code style fixes Apr 30, 2021
@tyrasd tyrasd changed the title code style fixes 🧹 code style fixes Apr 30, 2021
@tyrasd tyrasd changed the title 🧹 code style fixes 🧹 code style fixes Apr 30, 2021
@joker234 joker234 force-pushed the checkstyle-oshdb-api branch from 7a901bd to 112d2d3 Compare May 4, 2021 15:08
@tyrasd tyrasd force-pushed the checkstyle-oshdb-api branch from 99279a9 to a6199fd Compare May 4, 2021 15:40
rtroilo
rtroilo previously approved these changes May 5, 2021
Copy link
Copy Markdown
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about OSHDBTimestampInterval.compareTo/equals.

Copy link
Copy Markdown
Member Author

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtroilo , I looked through all changes and left (quite) some comments inline. In general it looks good, of course! 👍

Comment thread oshdb/src/main/java/org/heigit/ohsome/oshdb/index/XYGrid.java Outdated
@tyrasd tyrasd dismissed rtroilo’s stale review May 5, 2021 18:17

not ready yet :-P

@tyrasd tyrasd requested a review from rtroilo May 7, 2021 14:08
Copy link
Copy Markdown
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyrasd thank you for your effort.

@rtroilo rtroilo merged commit 4e59a5e into master May 7, 2021
@rtroilo rtroilo deleted the checkstyle-oshdb-api branch May 7, 2021 15:44
@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented May 7, 2021

@tyrasd thank you for your effort.

you too 😘

@tyrasd tyrasd mentioned this pull request May 10, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This will introduce an incombability to previous versions. Documentation update compulsory code quality Related to our standards for 'good' code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants