[oshdb-filter] allow filtering by changeset id and (optionally) contributor id#380
Merged
Conversation
tyrasd
force-pushed
the
filter-contributions
branch
6 times, most recently
from
fd3c79d to
df7615e
Compare
tyrasd
changed the title
rtroilo
requested changes
May 20, 2021
Member
There was a problem hiding this comment.
A very nice PR. I think we should also include
ChangesetIdFilterEqualsAnyOfContributorUserIdFilterEqualsAnyOf
as well. They should be very quick to implemented as far as I see the code.
In my opinion it could be a quite common use-case that you got a list of changeset ids and/or contributor ids which you want to use in a filter as well.
* check all possible cases for the "fallback" case for contribution view queries * add tests for changeset id and contributor user id filters
tyrasd
force-pushed
the
filter-contributions
branch
2 times, most recently
from
e8da0c9 to
3fa0cc1
Compare
tyrasd
force-pushed
the
filter-contributions
branch
from
3fa0cc1 to
19aef10
Compare
tyrasd
force-pushed
the
filter-contributions
branch
from
3c5bec7 to
23067fb
Compare
rtroilo
requested changes
May 27, 2021
Co-authored-by: Rafael Troilo <rafael.troilo@heigit.org>
Reason: They did not really fulfil a specific purpose because one can already "and" combine OSH+OSM filters by calling `.filter` twice, and the geometry callback filter basically just replicates the `.filter(Predicate)` anyway. Also the given documentation and examples were not in line with the actual behaviour when one would have negated the filter, so it in the end just confusing to use.
tyrasd
force-pushed
the
filter-contributions
branch
from
c8af432 to
9f8fecf
Compare
tyrasd
force-pushed
the
filter-contributions
branch
from
5e51a5c to
d130193
Compare
rtroilo
previously approved these changes
Jun 11, 2021
Member
rtroilo
left a comment
rtroilo
left a comment
There was a problem hiding this comment.
thank you for this pr!
I added a minor suggested change.
Co-authored-by: Rafael Troilo <rafael.troilo@heigit.org>
rtroilo
approved these changes
Jun 11, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enhances the oshdb-filter module to be able to filter by osm contributions or osm entity snapshots.
This can be used to implement further filters, like these two new ones:
changeset: <id>to filter contributions by changeset idcontributor: <id>to filter contributions by user id (disabled by default, can be activated by creating a filter parser with the respective optional boolean flag enabled)Corresponding issue
Closes #358
todo
Checklist
I have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository