Skip to content

fix serializability issue#417

Merged
tyrasd merged 10 commits into
masterfrom
revert_xygridtree_bbox2cellids
Aug 12, 2021
Merged

fix serializability issue#417
tyrasd merged 10 commits into
masterfrom
revert_xygridtree_bbox2cellids

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Aug 12, 2021

Description

Fixes a regression in 0.7.0 which made it impossible to run oshdb ignites on a ignite cluster backend. partially reverts #395 (75190d7).

Checklist

@tyrasd tyrasd added the bug Something isn't working as expected label Aug 12, 2021
@tyrasd tyrasd requested a review from rtroilo August 12, 2021 08:49
@tyrasd tyrasd force-pushed the revert_xygridtree_bbox2cellids branch from 2b83a99 to 3b762ac Compare August 12, 2021 09:44
@tyrasd tyrasd force-pushed the revert_xygridtree_bbox2cellids branch from 3b762ac to cf05112 Compare August 12, 2021 09:47
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Aug 12, 2021
@tyrasd tyrasd changed the title Revert xygridtree bbox2cellids fix serializability issue Aug 12, 2021
@joker234
Copy link
Copy Markdown
Member

There are a few new Code Smells reported by SonarCloud. Maybe you want to have a look at them before I continue to review the PR: https://sonarcloud.io/project/issues?branch=PR-417&id=org.heigit.ohsome%3Aoshdb

Copy link
Copy Markdown
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks good to me.

@tyrasd tyrasd merged commit 830de55 into master Aug 12, 2021
@tyrasd tyrasd deleted the revert_xygridtree_bbox2cellids branch August 12, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected waiting for review This pull request needs a code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants