🚧 change jdbc backend logic#422
Closed
tyrasd wants to merge 14 commits into
Closed
Conversation
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
Co-authored-by: Martin Raifer <martin.raifer@heigit.org>
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
* cells are fetched individually instead of in a single sql query * properly closes database resources see #419 (comment) for more background This reverts commit 69f958b.
3 tasks
tyrasd
commented
Aug 13, 2021
| var table = entry.getKey(); | ||
| var cellId = entry.getValue(); | ||
| var sqlQuery = String.format("select data from %s where level = ? and id = ?", table); | ||
| try (var pstmt = ((OSHDBJdbc) this.oshdb).getConnection().prepareStatement(sqlQuery)) { |
Member
Author
There was a problem hiding this comment.
@rtroilo would it make sense to store this in a shared prepared statement, instead of recreating it for every single fetching of a single grid cell (similar to how it is implemented in the tagtranslator)? or is that not possible because of concurrency issues (and if yes: could that be solved by using a connection pool instead of a single db connection)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corresponding issue
Was split off from #419, see #419 (comment)
Todo
Checklist