remove deprecated old type+tag filters and allow groupById and aggregatebyGeometry after mapping/filtering

[tyrasd]

addresses #324:

• removes old osmType filter methods
• removes old osmTag filter methods
• gets rid of (osmTag(key, valueRegexp)) method. reason: it was rarely used and never really worked when using an ignite backend. Also, it can be implemented relatively easily manually if needed in an analysis.
• implements groupById and aggregateByGeometry also after a filter, map or flatMap function was specified on a mapReducer. (solving the issue outlined in Removing deprecate MapReducerSettings #442 (comment))
  the following corner case still causes an UnsupportedOperationException: mapRed.filter("…").aggregateBy(…).aggregateByGeometry(…) but it can be worked around relatively easily by either swapping the two aggregateBy's (mapRed.filter("…").aggregateByGeometry(…).aggregateBy(…)) or by delaying the filtering (mapRed.aggregateBy(…).aggregateByGeometry(…).filter("…")).

Corresponding issue

Closes #324

Checklist

• My code follows the code-style rules, and I have checked on the static analyses and benchmark (if applicable) results
• I have commented my code
• I have written javadoc (required for public classes and methods)
• I have added sufficient unit tests
• I have made corresponding changes to the documentation
• I have updated the CHANGELOG.md
• I have adjusted the examples or created an issue in the corresponding repository
• [ ] I have adjusted the benchmark or created an issue in the corresponding repository

[tyrasd]

I'm not sure why this seemingly breaks the following two tests on Jenkins:

TestMapReduceOSHDBH2Singlethread.testTimeoutMapReduce Expected exception: org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException
TestMapReduceOSHDBH2Singlethread.testTimeoutStream Expected exception:org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException

These two tests work fine locally here. Will need to investigate 🤔

[rtroilo]

I'm not sure why this seemingly breaks the following two tests on Jenkins:

TestMapReduceOSHDBH2Singlethread.testTimeoutMapReduce Expected exception: org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException
TestMapReduceOSHDBH2Singlethread.testTimeoutStream Expected exception:org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException

These two tests work fine locally here. Will need to investigate thinking

Don't worry about this tests, we fixed them already in #450

[joker234]

I'm not sure why this seemingly breaks the following two tests on Jenkins:

TestMapReduceOSHDBH2Singlethread.testTimeoutMapReduce Expected exception: org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException
TestMapReduceOSHDBH2Singlethread.testTimeoutStream Expected exception:org.heigit.ohsome.oshdb.util.exceptions.OSHDBTimeoutException

These two tests work fine locally here. Will need to investigate thinking

Even though we fixed a lot in #450, the tests were still failing. I suspect that .filter(…) is much faster than .osmEntityFilter(…). The tests worked (locally) sometimes for me with a lower timeout setting (like 5 or 10 ms), sometimes not. With setting the timeouts to 1 ms it worked all the time (see 4704607).

[rtroilo]

What was the reason to change the order of the aggregation from timestamp, geometry to geometry, timestamp.

[tyrasd]

fixed in 40dba31 by simplifying the implementation of the "automatic" aggregation methods. As as sideeffect, now all(?) aggregation combinations are allowed and possible regardless of their order, for example: mapRed.aggregateByGeometry(…).aggregateByTimestamp() or mapRed.map(…).aggregateByTimestamp().aggregateByGeometry(…)

[rtroilo]

just a quick comment, why the widening to Object, see suggestions, is necessary. It seems for me that the tests run successfully through even without this.

[tyrasd]

just a quick comment, why the widening to Object, see suggestions, is necessary. It seems for me that the tests run successfully through even without this.

Good catch, you're right. It was probably an oversight / remainder of some intermediate change I made that wasn't necessary in the end. I've now restored the specific types in the cast.

[rtroilo]

Thank you .