Conversation
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
First review iteration, checked all code, will do another final check after the fixes! Please fix clippy, fmt and add a toolchain file.
These are the command as retrieved from ci.yaml
cargo +nightly fmt --allcargo clippy --workspace --all-features --all-targets -- -D warningsP.S. we can enable github actions for this repo, will need to review the ci config files first.
| chrono = { version = "0.4", default-features = false, features = ["alloc", "std"] } | ||
| thiserror = "1.0" | ||
| tokio = { version = "1.22", features = ["sync", "macros"] } | ||
| tokio-tungstenite-wasm = { git = "https://github.com/KomodoPlatform/tokio-tungstenite-wasm.git", rev = "8fc7e2f" } |
There was a problem hiding this comment.
Please note that we use a different revision in kdf https://github.com/KomodoPlatform/komodo-defi-framework/blob/8b1170d9f33208e1c260d94d9ef9a7eb492e1047/mm2src/coins/Cargo.toml#L112
You will need to update the kdf revision when you integrate this client in kdf.
|
@borngraced related to this #1 (review) fmt is not fixed yet. |
|
@borngraced I updated CI to run on PRs opened to kdf, please review the changes and fix CI problems (fmt, PR title, etc..) |
borngraced
changed the title
|
done @shamardy |
2 participants
Description
This pull request updates the crate to allow WebSocket client support for WebAssembly (WASM). Changes include:
httpfeature to enable or disablehttp client with reqwest crateinrelay_clientThese updates will enable users to utilize WebSocket client capabilities in WASM.
Resolves # (issue)
How Has This Been Tested?
Due Diligence