Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compatibility issue in Colab notebooks by downgrading the numpy version to ensure that PyMFEM’s dependency requirement (numpy < 2.0.0) is met.
- Updated pip install commands in three example notebooks to install numpy==1.26.4 alongside glvis.
- Corrected a typo and clarified the description in the README.md regarding the dependency chain.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/plot.ipynb | Changed pip command to pin numpy to version 1.26.4 for PyMFEM compatibility. |
| examples/ex9.ipynb | Changed pip command to pin numpy to version 1.26.4 for PyMFEM compatibility. |
| examples/ex1.ipynb | Changed pip command to pin numpy to version 1.26.4 for PyMFEM compatibility. |
| README.md | Updated diagram label and fixed a spelling error in the dependency explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colab notebooks have some default libraries that are automatically updated. It looks like they recently upgraded
numpyto>=2.0.0, whichPyMFEM(and other libraries) aren't supporting yet.PyMFEMspecifies it requiresnumpy < 2.0.0but it looks like the notebook isn't respecting that. This PR downgradesnumpyon the Colab notebooks