Solved bug in orientational_order_parameter().#114
Merged
andrewtarzia merged 1 commit intoGMPavanLab:mainfrom Aug 27, 2025
Merged
Solved bug in orientational_order_parameter().#114andrewtarzia merged 1 commit intoGMPavanLab:mainfrom
andrewtarzia merged 1 commit intoGMPavanLab:mainfrom
Conversation
andrewtarzia
approved these changes
Aug 26, 2025
Collaborator
|
Good solve - you can merge when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues: close #112
Requested Reviewers: @SimoneMartino98
The present code gives psi = 1.0 when only one neighbor is present. This is wrong, there is no order with only one neighbor, and it should be psi = 0.0. The new code fixes this.