Update to ORM 2.5 and PHP 7.4 #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2022 11:15
Generated by 'php composer.phar update' prior to updating composer.json for ORM 2.5 update.
After update to PHP7.4 but before change to ORM2.6.
ghost
self-requested a review
as a 
Member
|
I tired re-running the tests and they still failed, so I don't think it was a transient error. |
added 3 commits
June 29, 2022 15:41
Moving to PHP7.4 generates some Notice reports from the Doctrine code which cause tests to fail. This can be switched back on for later ORM versions where this is fixed.
As of PHP 7.2.0 count() yields a warning on invalid countable types passed to the value parameter.
ghost
mentioned this pull request
gregcorbett
approved these changes
Feb 23, 2023
Member
gregcorbett
left a comment
gregcorbett
left a comment
There was a problem hiding this comment.
LGTM, but will need rolling out with some thought.
gregcorbett
reviewed
Feb 23, 2023
| "doctrine/orm": "2.4.8", | ||
| "doctrine/dbal": "2.5.4" | ||
| }, | ||
| "doctrine/orm": "2.5.14" |
Member
There was a problem hiding this comment.
Rolling this out will require some thought from @gregcorbett
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR as requested - #344 (comment)
Also integrates fixes for misc PHP 7.4 notices and warnings 4b94276