Implemented the preferencesChanged event#125
Closed
tsakov wants to merge 7 commits intoGPII:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
This material, related to the "QuickEditor" should be broken out into a separate file (and grade) and not appear in the core definition of the FlowManager. However, the configuration itself is good.
Contributor
Author
There was a problem hiding this comment.
Recently Yura proposed that I write event listeners that deal with the caching of preferences for the preferencesChanged event. I was thinking of doing the same with the PCP (quickEditor). I'm trying to think of way to do it properly.
…in preferencesChanged.js
…ner to existing events.
Member
|
This pull request is outdated so closing and waiting for a new one with all the new PCP/PMT work that has been going on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.