GPII-1234: Create Settings File if it doesn't exist#382
Closed
xpheal wants to merge 5 commits intoGPII:masterfrom
Closed
GPII-1234: Create Settings File if it doesn't exist#382xpheal wants to merge 5 commits intoGPII:masterfrom
xpheal wants to merge 5 commits intoGPII:masterfrom
Conversation
|
Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test". |
Member
|
This is now resolved by #473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPII crashes when it tries to read a file that doesn't exists.
Some software such as JAWS and MAGIC doesn't have an initial settings file. GPII crashes when it tries to read a file that doesn't exists. Solution: Create an empty dummy file if the settings file doesn't exist before the settings handler starts to read the file.