GPII-1286: Fixed the chrome and easit4all tests to properly run again…#395
Merged
javihernandez merged 3 commits intoGPII:masterfrom Oct 8, 2015
Merged
GPII-1286: Fixed the chrome and easit4all tests to properly run again…#395javihernandez merged 3 commits intoGPII:masterfrom
javihernandez merged 3 commits intoGPII:masterfrom
Conversation
…. This involved separating out the testDefs into separate file and loading them from the standard and oauth tests
…hen a testDefinition passed as argument is shared between multiple files. The problem arises because the cloudbased buildTestFixture function modifies the object passed in the argument. This has bnow been fixed and everything is passing again (cheers @simonbates for finding the source of the error)
Member
Author
|
@javihernandez assigning to you for review - let me know if you prefer someone else to do it |
Member
There was a problem hiding this comment.
These tests are failing - it seems that you forgot adding gpii.loadTestingSupport();
…ed a comment describing the reason for copying the testdefs
Member
Author
|
@javihernandez addressed your comments - ready for another round of review |
javihernandez
added a commit
that referenced
this pull request
Oct 8, 2015
* kaspermarkus/GPII-1286: GPII-1286: Chrome Oauth2 tests are now able to run by themselves. Added a comment describing the reason for copying the testdefs GPII-1286: Fixed an issue with the cloudbased tests, where it fails when a testDefinition passed as argument is shared between multiple files. The problem arises because the cloudbased buildTestFixture function modifies the object passed in the argument. This has bnow been fixed and everything is passing again (cheers @simonbates for finding the source of the error) GPII-1286: Fixed the chrome and easit4all tests to properly run again. This involved separating out the testDefs into separate file and loading them from the standard and oauth tests
Member
There was a problem hiding this comment.
thanks for adding this comment!
Member
|
🍻 🍻 🍻 |
javihernandez
added a commit
that referenced
this pull request
Oct 8, 2015
* kaspermarkus/GPII-1286: GPII-1286: Chrome Oauth2 tests are now able to run by themselves. Added a comment describing the reason for copying the testdefs GPII-1286: Fixed an issue with the cloudbased tests, where it fails when a testDefinition passed as argument is shared between multiple files. The problem arises because the cloudbased buildTestFixture function modifies the object passed in the argument. This has bnow been fixed and everything is passing again (cheers @simonbates for finding the source of the error) GPII-1286: Fixed the chrome and easit4all tests to properly run again. This involved separating out the testDefs into separate file and loading them from the standard and oauth tests
Member
|
Merged into review4 (9d50f9f) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. This involved separating out the testDefs into separate file and loading them from the standard and oauth tests.
This error can be seen by running the cloudbased chrome and easit tests individually - in which case they dont do any asserts... Once merged, they should be running properly again, both individually and as part of all-tests.js