Closed
Conversation
added 3 commits
August 17, 2012 15:33
…o test it and ensure all tests refer to it, rather than the old test dir
…of the test libraries
gpii/index.js
Outdated
Member
There was a problem hiding this comment.
Hi Kasper, I believe we should not include testFramework as part of universal node_module. Given that this module is "require"ed for production we don't want to load the code that is specific to testing.
* GPII-16: GPII-16: Added configuration for overriding CouchDB data source type when in development mode. GPII-16: Updated couchdb data source. GPII-16: Updated couchdb data source to handle all id and rev business internally.
Member
|
So I wonder if it is sensible to be able to load testFramework based on NODE_ENV variable. So for example run your test with NODE_ENV=test set. This way in our gpii/index.js file you can have an additional line that checks whether the we are running tests and only then load testFramework as part of universal. @amb26 what do you think ? |
added 2 commits
October 2, 2012 11:24
… XML settingshandler now only requires the needed modules
….js, making everything nice and pretty for Yura to review
Member
Author
|
Closing -- this pull request now replaced by #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yura or Antranig,
Could you review this pull request? Testing framework is now a node module and the tests are updated to use that. Also, the old and hopelessly outdated integration test has been removed, soon to be replaced by a newer and working version.
~Kasper