GPII-2109: Google chrome now never reports as being installed#482
Merged
javihernandez merged 2 commits intoGPII:masterfrom Nov 9, 2016
Merged
GPII-2109: Google chrome now never reports as being installed#482javihernandez merged 2 commits intoGPII:masterfrom
javihernandez merged 2 commits intoGPII:masterfrom
Conversation
…ing the dynamic device reporter
|
CI job passed. |
Member
|
@kaspermarkus, Just one thing, since the chrome plugin is also being reported as installed when using the "dev" config, in order to avoid confusion, can you please remove the chrome plugin from our installedSolutions.json? |
|
CI job passed. |
Member
|
@kaspermarkus thanks!!! |
Member
|
merged at: e7b4f0d |
javihernandez
added a commit
to javihernandez/universal
that referenced
this pull request
Nov 23, 2016
Also: * updated the config that needs to be used for all test definitions * marked "com.ilunion.cloud4chrome" to not report itself as installed in linux as it was made for windows in GPII#482 (GPII-2109)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using the dynamic device reporter