GPII-3619: Convert universal tests to use CouchDB instead of PouchDB. by the-t-in-rtf · Pull Request #728 · GPII/universal

the-t-in-rtf · 2019-01-16T09:40:12Z

Replaces all node-side usages of PouchDB with gpii-couchdb-test-harness. See GPII-3619 for details. Fixes bugs discovered in using CouchDB for the tests, such as GPII-3628.

Also replaces a lot of legacy test-building code with modern sequence elements and grades.

…o flat.json5.

…AGic directly.

…ntry.

…cks into launch handler block. Removed duplicate capability definition after review of logs.

…ommon->JAWS settings.

…s and disabled TypingEcho, as it is known to cause problems.

…opefully avoid cross-pollenating data when values are unset.

… the innocent.

…nce set.

… Fixed typo in TextViewerFontFaceName inverse capability transform.

# Conflicts: # gpii/node_modules/testing/src/TestUtils.js # tests/UntrustedUserLogonRequestTests.js

amb26 · 2019-02-18T10:11:06Z

gpii/node_modules/testing/src/RunTestDefs.js

What do you mean by "we shouldn't use gradeNames"?

No idea, I didn't write that, I just moved it. Here it is in master.

Happy to bin it if it doesn't seem like a useful note for the future.

Yes, please bin - we can consider whatever intent was behind the comment is enacted moving to sequence grades

Done, will commit once I fix the broken prefs server tests.

amb26 · 2019-02-18T10:12:47Z

tests/shared/UserLogonRequestTestDefs.js

+        debounceTimeoutComplete: null
+    },
+    expectedModelChanges: {
+        proximityTriggeredLogon: [


I think this model makes a lot more sense

I'm glad, I was shooting for something clearer and reliable.

amb26 · 2019-02-18T10:15:30Z

tests/shared/DevelopmentTestDefs.js

Stray commented out definition

Thanks, that was left over from a fairly serious goof with a broken environment where that grade was required.

amb26 · 2019-02-18T10:16:27Z

tests/shared/PSPIntegrationTestDefs.js

-                    listener: "fluid.identity"
-                }
-            ]
+            {


Any chance we could lose the massive formatting diffs in this file?

As stated above, I really really dislike not indenting multi-element arrays, and indenting them more cleanly made it easier to do the review work required for this pull. I think of it as something akin to alphabetising a previously unordered list of solutions registry entries. It made it easier to perform the work in question today, and hopefully will make it easier to maintain things in the future, even if it does bloat the pull.

In follow up work I have noticed additional small multi-element arrays and left them alone for now.

amb26 · 2019-02-18T10:17:12Z

tests/PSPIntegrationTests.js

Indeed, don't!

Ha, thanks, fixed.

tests/UntrustedPSPIntegrationTests.js

the-t-in-rtf · 2019-02-18T10:33:00Z

All of my "done" and "fixed" comments above are pending a local test run and will soon be committed.

the-t-in-rtf · 2019-02-18T10:38:11Z

Rather than doing a double tap, I decided to commit so that my changes were visible, and then look at the results in CI.

gpii-bot · 2019-02-18T11:02:49Z

CI job failed: https://ci.gpii.net/job/universal-tests/1543/

the-t-in-rtf · 2019-02-18T11:40:42Z

Looks like the commented out configurations in the preferences server tests are actually broken, fixing those now.

…un without a db. Commented out because of bug revealed.

the-t-in-rtf · 2019-02-18T13:16:22Z

I fixed one of the commented out tests easily enough, but I ended up uncovering a bug with the "without db" variants that I wrote up as GPII-3733. Those tests are commented out for now.

gpii-bot · 2019-02-18T13:32:49Z

CI job passed: https://ci.gpii.net/job/universal-tests/1546/

amb26 · 2019-02-19T12:48:55Z

gpii/configs/gpii.config.untrusted.production.dynamicDR.all.local.json5

Should read CouchDB

amb26 · 2019-02-19T12:49:06Z

gpii/configs/gpii.config.untrusted.development.all.local.json5

Should read CouchDB

amb26 · 2019-02-19T12:56:03Z

tests/shared/UserLogonRequestTestDefs.js

Anomalous spacing appeared here

It's aligned in the way I often do, and is consistent with itself, but I see that the rest of the test defs follow another style. I'll change it.

amb26 · 2019-02-19T13:05:54Z

Please do a search throughout the project for "Pouch" and remove all stray references - I find 29 still remaining

the-t-in-rtf · 2019-02-20T09:55:48Z

Sorry, I think my last search for all references to "pouch" may have either been case-sensitive or otherwise incomplete. Will fix it now.

…umentation.

the-t-in-rtf · 2019-02-20T10:24:23Z

@amb26, this should be ready to review again.

gpii-bot · 2019-02-20T10:37:17Z

CI job failed: https://ci.gpii.net/job/universal-tests/1548/

the-t-in-rtf · 2019-02-20T10:40:45Z

Looks like the merge with upstream brought in "new old world" tests that I need to quickly update:

10:34:38.539: FATAL ERROR: Uncaught exception: gpii.test.bootstrapServer is not a function
TypeError: gpii.test.bootstrapServer is not a function
at Object. (/home/vagrant/sync/universal/tests/SuppressHttpEndpointsTests.js:20:11)

…pii.test.runCouchTestDefs` method.

gpii-bot · 2019-02-20T11:23:07Z

CI job passed: https://ci.gpii.net/job/universal-tests/1549/

the-t-in-rtf added 30 commits December 4, 2018 15:44

GPII-3555: Initial onboarding of MAGic 14.0.

e338e3b

GPII-3555: (re)Added generic preference for "magnification enabled" t…

9c4b1d1

…o flat.json5.

GPII-3555: Renamed MAGic settings handlers.

699bfb9

GPII-3555: Removed toothless "metadata" block in favor of launching M…

b0ff6f6

…AGic directly.

GPII-3555: Temporarily changed MAGic namespace to test a theory.

d4da6ee

GPII-3555: Removed alternate namespacing. Added capability to MAGic e…

af157ec

…ntry.

GPII-3555: Refactored old "start", "stop", "configure", "restore" blo…

41b8929

…cks into launch handler block. Removed duplicate capability definition after review of logs.

Further cleaned up MAGic entry after figuring out JAWS crosswalk issues.

f4b8c6d

GPII-3555: Updated getState check for MAGIC entry.

8f5d2ed

GPII-3555: Attempting to manually disable launch of JAWS via MAGIC->c…

ab588e1

…ommon->JAWS settings.

GPII-3555: Fixed casing issue with "size" inverse transform.

8093c90

GPII-3555: Tagged all test settings with associated inverse transform…

db85d24

…s and disabled TypingEcho, as it is known to cause problems.

GPII-3555: Temporarily disabled all terms with common equivalents.

225dc29

GPII-3555: Refactored MAGic inverse capabilities transformations to h…

9547431

…opefully avoid cross-pollenating data when values are unset.

GPII-3555: Disabled additional problematic test setting and reenabled…

f9c638e

… the innocent.

GPII-3555: Turned magnification on by default in sample MAGic prefere…

1550cb2

…nce set.

GPII-3555: Removed inverse capability transform for "startmagnified".…

cd55c16

… Fixed typo in TextViewerFontFaceName inverse capability transform.

GPII-3555: Added test definitions for MAGic.

adda3d0

Merge remote-tracking branch 'upstream/master' into GPII-3555

22b9f18

GPII-3619: Initial work in progress refactoring to avoid using pouchDB.

64dd242

Merge remote-tracking branch 'upstream/master' into GPII-3619

401b014

GPII-3628: Avoid using null _id values in views.

91ffd07

GPII-3619: Updated DbDataStore tests to use CouchDB.

1035366

GPII-3594: Temporary fix for duplicate sessions.

1e96a13

GPII-3619: Factored out sequence-munging from error tests.

951f0ce

GPII-3619: Converted cloud platform tests.

c29e57c

GPII-3619: Tidied up key names.

b7e3296

Merge remote-tracking branch 'upstream/master' into GPII-3619

23904d0

# Conflicts: # gpii/node_modules/testing/src/TestUtils.js # tests/UntrustedUserLogonRequestTests.js

GPII-3619: Updated various comments regarding "pouch".

89cedbd

Collapsed pouchConfig option used with previous test harness.

373c25e

amb26 reviewed Feb 18, 2019

View reviewed changes

tests/UntrustedPSPIntegrationTests.js Show resolved Hide resolved

GPII-3619: Addressed PR feedback.

e8d4f40

the-t-in-rtf added 4 commits February 18, 2019 12:41

Merge remote-tracking branch 'upstream/master' into GPII-3619

52d6a10

GPII-3619: Consigned cryptic old TODO to the dustbin of history.

dcf0923

GPII-3619: Added missing @return to JSDoc.

ca2da0d

GPII-3619: Updated preferences server "without db" test to actually r…

8616767

…un without a db. Commented out because of bug revealed.

amb26 reviewed Feb 19, 2019

View reviewed changes

the-t-in-rtf added 2 commits February 20, 2019 11:22

GPII-3619: Purged remaining references to "pouch" in comments and doc…

bd7a310

…umentation.

Merge remote-tracking branch 'upstream/master' into GPII-3619

330fe71

GPII-3619: Updated tests brought in by upstream merge to use newer `g…

ec90b2f

…pii.test.runCouchTestDefs` method.

amb26 merged commit ec90b2f into GPII:master Feb 20, 2019

Conversation

the-t-in-rtf commented Jan 16, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

the-t-in-rtf commented Feb 18, 2019

Uh oh!

the-t-in-rtf commented Feb 18, 2019

Uh oh!

gpii-bot commented Feb 18, 2019

Uh oh!

the-t-in-rtf commented Feb 18, 2019

Uh oh!

the-t-in-rtf commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpii-bot commented Feb 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amb26 commented Feb 19, 2019

Uh oh!

the-t-in-rtf commented Feb 20, 2019

Uh oh!

the-t-in-rtf commented Feb 20, 2019

Uh oh!

gpii-bot commented Feb 20, 2019

Uh oh!

the-t-in-rtf commented Feb 20, 2019

Uh oh!

gpii-bot commented Feb 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

the-t-in-rtf commented Feb 18, 2019 •

edited

Loading