Window creation lock-up fix#119
Merged
DominikWitczakAMD merged 1 commit intoGPUOpen-Archive:masterfrom Nov 5, 2018
Merged
Conversation
1) Window thread T1 became temporarily unresponsive, waiting for T2 to finish 2) Thread T2 tried to create an Anvil window instance for window owned by T1. The lock-up occurred because GetWindowTextLength() actually maps to a window message which cannot be handled because T1 is waiting on T2. There's no real solution other than just getting rid of the circular dependency, meaning we need Anvil to stop trying to retrieve window name at Anvil::Window creation time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a lock-up which could occur if:
The lock-up occurred because GetWindowTextLength() actually maps to a window message which cannot
be handled because T1 is waiting on T2. There's no real solution other than just getting rid of
the circular dependency, meaning we need Anvil to stop trying to retrieve window name at Anvil::Window
creation time.