Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Support 32bit predicates on the universal engine on GFX6-8.#69

Merged
JakeMerdichAMD merged 1 commit into
GPUOpen-Drivers:devfrom
DadSchoorse:gfx6-32-predicates
Jun 28, 2021
Merged

Support 32bit predicates on the universal engine on GFX6-8.#69
JakeMerdichAMD merged 1 commit into
GPUOpen-Drivers:devfrom
DadSchoorse:gfx6-32-predicates

Conversation

@DadSchoorse
Copy link
Copy Markdown
Contributor

Basically a port of the gfx9 fallback path. Passes the VK_EXT_conditional_rendering CTS tests on polaris12. VK_EXT_conditional_rendering should now finally be exposed on all gpus using amdvlk.

@amdvlk-admin
Copy link
Copy Markdown

Can one of the admins verify this patch?

Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
@JaxLinAMD
Copy link
Copy Markdown
Contributor

ok to test

@JaxLinAMD JaxLinAMD requested a review from JakeMerdichAMD June 21, 2021 03:25
@amdvlk-admin
Copy link
Copy Markdown

Test summary for commit 3405b2e

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • LLPC: dev 4d4d97e4f27426cdd72923ea6db7bde4e646514a
  • SPVGEN: dev 79f8e32dd7242d7d34fa0074f761c9d794f11811
  • XGL: dev 290c9fc19eab37d76cbbffa718782210f6760fed
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 2ef30b5c551e59a65df0243d684464afb074a590
CTS tests (Failed: 0/228128)
  • Built with version 1.2.5.2
  • Rhel 8.2, Gfx10
    • Passed: 31146/57032 (54.6%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25886/57032 (45.4%)
    Ubuntu 18.04, Gfx9
    • Passed: 31145/57032 (54.6%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25887/57032 (45.4%)
    Ubuntu 20.04, Gfx8
    • Passed: 31459/57032 (55.2%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25573/57032 (44.8%)
    Ubuntu 20.04, Gfx103
    • Passed: 34853/57032 (61.1%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 22179/57032 (38.9%)

Copy link
Copy Markdown
Contributor

@JakeMerdichAMD JakeMerdichAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding this!

@JakeMerdichAMD JakeMerdichAMD merged commit 93d6aba into GPUOpen-Drivers:dev Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants