Bump cmake minimum version to 3.24, required for CMP0135 policy support#51
Merged
miguel-petersen merged 1 commit intoGPUOpen-Tools:mainfrom Jan 22, 2024
Merged
Conversation
Collaborator
|
Nice catch moarmand! Could you please prepend the commit message with [Build], such that it would read "[Build] Bump cmake ...". |
Contributor
Author
|
Sure, that should be all good now. |
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue while trying to generate visual studio solutions. It turns out my cmake version was too old and according to the documentation (https://cmake.org/cmake/help/latest/policy/CMP0135.html) CMP0135 has only been introduced in cmake 3.24.