Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 99.73% 99.52% -0.22%
==========================================
Files 14 9 -5
Lines 757 838 +81
==========================================
+ Hits 755 834 +79
- Misses 2 4 +2
Continue to review full report at Codecov.
|
… objectives Fixed hvPoI to allow just one model based on multiple objectives
Contributor
Next up: removing obsolute code in the cell bound calculation, and making it faster if possible. |
… cells. Final cells are still stored as a numpy array (DataHolder in BoundedVolume)
… a generic_strategy argument
… and should improve performance a little. Added more doc strings
Contributor
|
While originally for GPflowOpt 0.2, we are thinking of merging this multiobjective acquisition function for 0.1:
If noone has objections I will merge it in a couple of days |
icouckuy
approved these changes
Aug 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the HvPoI multi-objective optimization algorithm. Before this can be merged some steps are required.
I'm quite ok with the acquisition implementation, however I can't say the same about the Pareto class. This code is the result of two refactors based on port of the original MATLAB code. I think it already looks better but as several multi-objective strategies are based on hypervolumes, this makes that class quite significant in our framework. Its not up to standards yet. It also needs documentation. To improve this, I'm counting on you @icouckuy . Currently, our test coverage also misses 2 lines in pareto.py, but I understood the levels of improvement can be removed?
In addition, a notebook might be interesting also.