Conversation
…hanging free state) #58
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 16 16
Lines 932 932
=======================================
Hits 930 930
Misses 2 2
Continue to review full report at Codecov.
|
Contributor
|
Has the model optimization strategy been documented anywhere? Just in case if the user decides to use 1 restart and thus starts from potential very bad hyps with no model.randomize() before. |
Member
Author
|
Right now it isn't, was planning to do so when I add the callback option to override the default behavior in the optimize step. |
Closed
icouckuy
approved these changes
Aug 8, 2017
Contributor
|
I think this should wait until the notebook tests have been merged (#49). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposed changes of #58
Also required to support VGP.