This repository was archived by the owner on Aug 5, 2021. It is now read-only.
Added open in mail client functionality to email link within repo.com…#520
Merged
DanielJDufour merged 1 commit intoGSA:masterfrom Apr 2, 2018
Merged
Conversation
…ponent Mail client opens with default subject of and uses the href tag attribute which opens the document in the full body of the browser window
Contributor
|
Hi @kerrynordstrom. Thanks for the PR! 😄 The error in the tests is not code related. I think there is a misconfiguration in CircleCI that is causing it. We will take a look and let you know what going on. |
Contributor
|
@kerrynordstrom , looks good. I'm merging now! |
DanielJDufour
approved these changes
Apr 2, 2018
Contributor
DanielJDufour
left a comment
DanielJDufour
left a comment
There was a problem hiding this comment.
I manually tested locally and site works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mail client opens with default subject of "Contribution Inquiry" and uses the "_top" href tag attribute which opens the document in the full body of the browser window
Summary
This PR adds the ability for a user to click the email address of the project owner which opens a new window with the subject line "Contribution Inquiry".
This PR fixes/implements the following bugs/features
Improves page interaction by allowing clickable email link and opening of user's native email client
Adding this feature makes it easier for a user to contact a project owner to request more information about the library/API/project. The link opens in the user's default email client and eliminates the potential for the user to miscopy or mistype the project owner's email address.
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
npm start runs the webpack build and the following screenshots are taken from my localhost:2700 deployment:
Fixes #491