Skip to content
This repository was archived by the owner on Aug 5, 2021. It is now read-only.

Updated schema 2.0.0 with schema used in API harvester#530

Merged
DanielJDufour merged 1 commit intomasterfrom
update-schema-2.0
Apr 4, 2018
Merged

Updated schema 2.0.0 with schema used in API harvester#530
DanielJDufour merged 1 commit intomasterfrom
update-schema-2.0

Conversation

@froi
Copy link
Copy Markdown
Contributor

@froi froi commented Apr 4, 2018

Summary

Updated schema 2.0 that is being used in the validator to be the same as the schema used in our harvesting and validating process in the API

This PR fixes/implements the following bugs/features

Explain the motivation for making this change. What existing problem does the pull request solve?

The 2.0.0 schema was defining required fields incorrectly and creating validation errors for our users that were incorrect.

Test plan (required)

image

Closing issues

Closes #529

@froi froi requested a review from DanielJDufour April 4, 2018 18:16
@froi froi changed the title Updated schema 2.0,0 with schema used in API harvester Updated schema 2.0.0 with schema used in API harvester Apr 4, 2018
@DanielJDufour DanielJDufour merged commit 2e9fd27 into master Apr 4, 2018
@DanielJDufour DanielJDufour deleted the update-schema-2.0 branch April 4, 2018 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible JSON schema syntax issue

2 participants