Enhancement and bugfix for concept class#103
Merged
jbrown-xentity merged 4 commits intomainfrom Apr 3, 2026
Merged
Conversation
…rrent allowances.
jbrown-xentity
added
bug
zopalmer14
approved these changes
Mar 26, 2026
zopalmer14
left a comment
zopalmer14
left a comment
There was a problem hiding this comment.
LGTM. Great work with the examples. They're very thorough and I'm sure users will appreciate them. I left one tiny comment on the description for notation but it's trivial.
neilmb
approved these changes
Mar 26, 2026
zopalmer14
added a commit
that referenced
this pull request
Mar 31, 2026
Relevant classes: Activity, Agent, Catalog, Data Service, Dataset, Document, and Standard Changes: - change 'category' from a single entry to a list in all relevant classes but Dataset (it's already a list here) - replace 'oneOf' with 'anyOf' and 'flatten' in line with PR #103 - fix property descriptions for consistency and to align with changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update concept class, provide examples, edit previous examples for current allowances.
Should resolve #91 . The main change in this are 2 fold:
This then provides simple and complete (every possible field filled in) examples for both the Concept class and an implementation of it with the Agent class. In order for tests to pass, I had to implement the
anyOfinstead ofoneOf, but full implementation of that will be handled in #90 (not this pull request).