Replace all 'oneOf' with 'anyOf' and 'flatten' where appropriate#113
Merged
neilmb merged 2 commits intotiger-teamfrom Apr 3, 2026
Merged
Replace all 'oneOf' with 'anyOf' and 'flatten' where appropriate#113neilmb merged 2 commits intotiger-teamfrom
neilmb merged 2 commits intotiger-teamfrom
Conversation
Changes: - replace all instances of 'oneOf' with 'anyOf' - flatten 'anyOf' structures with null and array if they aren't too complicated
zopalmer14
changed the title
jbrown-xentity
approved these changes
Mar 31, 2026
Collaborator
jbrown-xentity
left a comment
jbrown-xentity
left a comment
There was a problem hiding this comment.
I pulled the branch and confirmed no other usage of oneOf exists, and all these changes look good! This is ready for merging with Tiger Team approval...
| { | ||
| "type": "string", | ||
| "description": "reference iri of Person", | ||
| "description": "reference iri of author", |
Collaborator
There was a problem hiding this comment.
Good drive-by improvement!
zopalmer14
added a commit
that referenced
this pull request
Mar 31, 2026
Relevant classes: Activity, Agent, Catalog, Data Service, Dataset, Document, and Standard Changes: - change 'category' from a single entry to a list in all relevant classes but Dataset (it's already a list here) - replace 'oneOf' with 'anyOf' and 'flatten' in line with PR #113 - fix property descriptions for consistency and to align with changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve: #90
Note: This PR only affects the JSON conventions/structure and does not change/alter the schema
Changes:
oneOfwithanyOfanyOfstructures with type null or array if they aren't too complicated